Remove deprecations in JdbcChatMemory #3002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThomasVitale
commented
May 5, 2025
ThomasVitale
commented
- Remove deprecated APIs for JdbcChatMemory.
- Improve documentation about chat memory vs. chat history.
- Fix mismatch between docs vs code for max messages in MessageWindowChatMemory.
* Remove deprecated APIs for JdbcChatMemory. * Improve documentation about chat memory vs. chat history. * Fix mismatch between docs vs code for max messages in MessageWindowChatMemory. Signed-off-by: Thomas Vitale <[email protected]>
markpollack
reviewed
May 6, 2025
| @@ -40,7 +40,7 @@ | |||
| */ | |||
| public final class MessageWindowChatMemory implements ChatMemory { | |||
|
|
|||
| private static final int DEFAULT_MAX_MESSAGES = 200; | |||
| private static final int DEFAULT_MAX_MESSAGES = 20; | |||
There was a problem hiding this comment.
@ThomasVitale how did you come up with 20 as a heuristic BTW?
|
merged in 356a68f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.