GH-922: Add Batch-mode @RabbitListener #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#922 - remove unnecessary back-ticks from literal table columns
artembilan
requested changes
Apr 12, 2019
| .acceptIfNotNull(endpoint.getTaskExecutor(), instance::setTaskExecutor); | ||
| .acceptIfNotNull(endpoint.getAutoStartup(), instance::setAutoStartup) | ||
| .acceptIfNotNull(endpoint.getTaskExecutor(), instance::setTaskExecutor); | ||
| javaUtils |
There was a problem hiding this comment.
Looks like this can be combined with the previous chain.
There was a problem hiding this comment.
I thought it was a bit dirty to do that since the property receiver is a different object; I kept changing my mind but ended up with this.
Feel free to change if you feel strongly.
| this.batchingStrategy = batchingStrategy; | ||
| } | ||
|
|
||
| @SuppressWarnings("deprecation") |
There was a problem hiding this comment.
Doesn't look like there is some in the method below to suppress.
| return new GenericMessage<>(messages); | ||
| } | ||
| else { | ||
| List<Object> list = new ArrayList<Object>(); |
There was a problem hiding this comment.
We can use diamond operator.
|
|
||
| public static class Listener { | ||
|
|
||
| List<Foo> foos; |
There was a problem hiding this comment.
Time to ditch foos and bars? 😉
There was a problem hiding this comment.
While I understand Jay's point about docs, I don't think we have to change all of our tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #922