Polish LDAP Test to Confirm Authenticated#337
Open
jzheaux wants to merge 1 commit intospring-projects:mainfrom
Open
Polish LDAP Test to Confirm Authenticated#337jzheaux wants to merge 1 commit intospring-projects:mainfrom
jzheaux wants to merge 1 commit intospring-projects:mainfrom
Conversation
This commit updates a test that confirms the users is successfully authenticated. It uses SecurityMockMvcResultMatchers to check the SecurityContextHolder. It further updates one of the assertions which was working only when the resulting JSON was malformed. Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
jzheaux
force-pushed
the
update-ldap-json-assertion
branch
from
a3df197 to
a1c06d8
Compare
Member
|
Thanks @jzheaux. Is this change only to be applied for the latest version of Spring LDAP or does it make sense for maintenance releases as well? |
philwebb
added
status: waiting-for-internal-feedback
and removed
status: waiting-for-feedback
labels
snicoll
added
status: waiting-for-feedback
and removed
status: waiting-for-internal-feedback
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates a test that confirms the users is successfully authenticated. It uses
SecurityMockMvcResultMatchersto check theSecurityContextHolder.It further updates one of the assertions which was working only when the resulting JSON was malformed.