Jackson2 AOT contribution not registered when extending JdbcOAuth2AuthorizationService

[billkoch]

Expected Behavior
When extending the JdbcOAuth2AuthorizationService or JdbcRegisteredClientRepository, the Jackson2ConfigurationBeanRegistrationAotContribution should be registered.

Current Behavior
The Jackson2ConfigurationBeanRegistrationAotContribution is not registered as an AOT contribution.

Context
This is due to the OAuth2AuthorizationServerBeanRegistrationAotProcessor checking for the relevant classes by the String class name (i.e. "org.springframework.security.oauth2.server.authorization.JdbcOAuth2AuthorizationService" and "org.springframework.security.oauth2.server.authorization.client.JdbcRegisteredClientRepository").

My current workaround is to provide my own BeanRegistrationAotProcessor implementation that JdbcOAuth2AuthorizationService and JdbcRegisteredClientRepository are assignable from registeredBean.getBeanClass(), and then use reflection to instantiate the package-private Jackson2ConfigurationBeanRegistrationAotContribution:

@Override
public BeanRegistrationAotContribution processAheadOfTime(RegisteredBean registeredBean) {
    boolean isJdbcBasedOAuth2AuthorizationService =
        JdbcOAuth2AuthorizationService.class.isAssignableFrom(registeredBean.getBeanClass());

    boolean isJdbcBasedRegisteredClientRepository =
        JdbcRegisteredClientRepository.class.isAssignableFrom(registeredBean.getBeanClass());

    BeanRegistrationAotContribution contribution = null;
    if ((isJdbcBasedOAuth2AuthorizationService || isJdbcBasedRegisteredClientRepository)
        && !this.jackson2Contributed) {

    this.jackson2Contributed = true;
    contribution = createJackson2ConfigurationBeanRegistrationAotContribution();
    }
    return contribution;
}

Is there a reason to use String-based class references over Class references?

[billkoch]

I would be happy to work on a pull request if my proposed changes make sense.

[jgrandja]

@billkoch Thank you for reporting this.

Is there a reason to use String-based class references over Class references?

I'm not sure why the String-based class equality check was used but it should use the class reference instead, as per your workaround.

Would you be interested in submitting a PR for this fix?

[billkoch]

@jgrandja Thank you for the quick response! I'd be happy to submit a PR for this. 👍

[billkoch]

@jgrandja I opened #1778 to address this. Please let me know what you think.