Skip to content

Add Authorization Code Grant sample #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dfcoffin opened this issue Apr 16, 2020 · 6 comments
Closed

Add Authorization Code Grant sample #25

dfcoffin opened this issue Apr 16, 2020 · 6 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@dfcoffin
Copy link

dfcoffin commented Apr 16, 2020

This sample should integrate with spring-security-oauth2-client and spring-security-oauth2-resource-server.

@dfcoffin dfcoffin added the type: enhancement A general enhancement label Apr 16, 2020
@andifalk
Copy link

andifalk commented Apr 16, 2020

With the authorization grant, you actually mean the authorization code grant?

If yes, then we also need an epic for authorization code grant first (same as for client credentials). Especially as the authorization code grant is more complex than the client credentials grant type.
And authorization code grant also must support PKCE.

@jgrandja
Copy link
Collaborator

@dfcoffin Can you please provide details on this issue.

@jgrandja jgrandja added the status: waiting-for-feedback We need additional information before we can continue label Apr 16, 2020
@dfcoffin
Copy link
Author

@andifalk Yes, I mean the authorization code grant. I attempted to create an epic but was unable to post it, so I provided the Feature issue. We can add an authorization code grant epic and reference it here.

I agree the authorization grand also should support PKCE, as an optional value and will update the request. I used the Authorization Code Grant section of RFC 6749 to define the issue, without also referencing the additional RFCs that have been adopted since the publication of RFC 6749.

Perhaps a possible approach is to define an epic for each of the OAuth 2.0 "stand-alone" RFC and then issues can be tied to them.

@jgrandja
Copy link
Collaborator

@dfcoffin @andifalk Yes, the plan is to group a major feature using epics. I'm actually planning on logging a bunch of issues for the authorization_code grant and grouping it into this epic. However, our goal really is to flush out #19 first and then work on authorization_code. That may change though if we have contributors working on both flows :)

@jgrandja jgrandja changed the title Add Authorization Grant sample Add Authorization Code Grant sample Apr 16, 2020
@dfcoffin
Copy link
Author

@jgrandja Is the plan to continue tracking this project in the spring-security-oauth Gitter channel or will there be a spring-authorization-server channel established since spring-security-oauth is actively being implemented and will be supported by Pivotal until March 2021, I believe.

@jgrandja
Copy link
Collaborator

Good question. Let me run it by the team and see if it makes sense to setup a new Gitter channel.

@jgrandja jgrandja added status: on-hold We can't start working on this issue yet and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 21, 2020
@jgrandja jgrandja self-assigned this Aug 18, 2020
@jgrandja jgrandja removed the status: on-hold We can't start working on this issue yet label Aug 18, 2020
@jgrandja jgrandja added this to the 0.0.1 milestone Aug 18, 2020
jgrandja added a commit that referenced this issue Aug 19, 2020
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants