Skip to content

Registration access token cannot be de-serialized when calling Client Configuration Endpoint #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Nov 16, 2021 · 2 comments
Labels
type: bug A general bug
Milestone

Comments

@ghost
Copy link

ghost commented Nov 16, 2021

Because the initial registration access token saves the authorized scope in a SingletonSet when calling the Client Configuration Endpoint the access token cannot be deserialized because there's no Mixin registered.

A new mixin and custom deserializer should be registered in OAuth2AuthorizationServerJackson2Module

@jgrandja
Copy link
Collaborator

jgrandja commented Nov 16, 2021

@ovidiupopa91 Instead of

A new mixin and custom deserializer

Changing Collections.singleton() to new HashSet() would be the easiest fix.

@ghost
Copy link
Author

ghost commented Nov 16, 2021

@jgrandja that's true. This is how it was initially, but in your polish commit you've changed it and I think it makes sense to have an immutable Set here. I can change it to Collections.unmodifiableSet as we already have a mixin registered for UnmodifiableSet

ghost pushed a commit to ovidiupopa07/spring-authorization-server that referenced this issue Nov 16, 2021
@jgrandja jgrandja assigned ghost Nov 17, 2021
@jgrandja jgrandja added this to the 0.2.1 milestone Nov 17, 2021
ghost pushed a commit to ovidiupopa07/spring-authorization-server that referenced this issue Nov 17, 2021
Change the authorized scopes Set from SingletonSet to UnmodifiableSet as there is no mixin registered for SingletonSet

Closes spring-projectsgh-495
ghost pushed a commit to ovidiupopa07/spring-authorization-server that referenced this issue Nov 30, 2021
Change the authorized scopes Set from SingletonSet to UnmodifiableSet as there is no mixin registered for SingletonSet

Closes spring-projectsgh-495
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
Change the authorized scopes Set from SingletonSet to UnmodifiableSet as there is no mixin registered for SingletonSet

Closes spring-projectsgh-495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant