-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Token Revocation Endpoint is not getting called in case of Public Client #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As per Section 2.1 Revocation Request:
The (confidential) client MUST authenticate at the Token Revocation Endpoint. Public clients are not allowed. |
https://datatracker.ietf.org/doc/html/rfc7009#section-5 ("security considerations") says:
So, token revocation is allowed for public clients. |
@stefanocke I don't agree. It does not explicitly state that public clients are allowed. Regardless, allowing public clients on the token revocation endpoint goes against the "secure by default" principle, which is not what this project wants to adhere to. If you require unauthenticated access for clients to any of the endpoints, it's the applications responsibility to configure. |
Okay, that's only fair and consistent with the approch in #1430
Please let my try to rephrase my somehow shortened statement. Since in this case, my intent to do so by a custom configuration would just be wrong... |
Hello,
In my configuration, I have set
clientAuthenticationMethod(ClientAuthenticationMethod.NONE)
, also I haveIt seems neither
revocationResponseHandler
is called norOAuth2TokenRevocationEndpointFilter.doFilterInternal
.They are called if I use
clientAuthenticationMethod(ClientAuthenticationMethod.CLIENT_SECRET_POST)
.I was wondering if it is a bug or token revocation cannot be done in case the client is Public.
Regards
The text was updated successfully, but these errors were encountered: