Skip to content

accessTokenHttpResponseConverter and errorHttpResponseConverter allow custom #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

luamas
Copy link

@luamas luamas commented Feb 3, 2023

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 3, 2023
@jgrandja
Copy link
Collaborator

jgrandja commented Feb 3, 2023

@luamas We do not want to expose HttpMessageConverter<OAuth2AccessTokenResponse> or HttpMessageConverter<OAuth2Error>. The main extension points for customizing the access token response and error response are AuthenticationSuccessHandler and AuthenticationFailureHandler.

Please see this comment for further details.

Also, for future reference, please log the issue first and let's discuss the proposal to see if it will be accepted or not. This will avoid any unnecessary work. Thank you.

@jgrandja jgrandja closed this Feb 3, 2023
@jgrandja jgrandja self-assigned this Feb 3, 2023
@jgrandja jgrandja added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants