Skip to content

Issue 1246 adding debug log entry #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Issue 1246 adding debug log entry #1261

wants to merge 5 commits into from

Conversation

fndejan
Copy link
Contributor

@fndejan fndejan commented Jun 10, 2023

Hi, here is the PR for issues: #1245, #1246, #1247, and #1248.

Added debug log entries when:

  • Invalid redirect_uri and scope
  • Invalid client_secret
  • Missing code_verifier
  • Missing code_challenge

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 10, 2023
@sjohnr sjohnr added status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 13, 2023
@sjohnr sjohnr added this to the 1.2.0-M1 milestone Jun 13, 2023
@sjohnr
Copy link
Contributor

sjohnr commented Jun 13, 2023

Thanks @fndejan! This is merged as 6b6b211. I also added a polish commit 8d54f16.

@sjohnr sjohnr closed this Jun 13, 2023
@jgrandja jgrandja modified the milestones: 1.2.0-M1, 1.2.0-M2 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjohnr sjohnr

@fndejan fndejan

Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
1.2.0-M1
Development

Successfully merging this pull request may close these issues.
4 participants
@fndejan @sjohnr @jgrandja @spring-projects-issues