-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Refresh Token grant support #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @jgrandja, this one is ready for your review. A couple of things I'd like to discuss before implementing are:
Also there is a bit of code repetition in |
Let's introduce
Let's introduce
I'm planning on introducing |
212c39a
to
80f073d
Compare
2138e83
to
9381ffe
Compare
Thanks @jgrandja, all done now. Feel free to review whenever you are ready. Also, this PR only covers opaque refresh tokens. Do you think JWT tokens should be supported as a part of this PR as well? |
a19daab
to
77ab3f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @alek-sys ! Please see review comments.
...auth2/server/authorization/authentication/OAuth2AuthorizationCodeAuthenticationProvider.java
Show resolved
Hide resolved
...auth2/server/authorization/authentication/OAuth2AuthorizationCodeAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...auth2/server/authorization/authentication/OAuth2ClientCredentialsAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...auth2/server/authorization/authentication/OAuth2AuthorizationCodeAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...ity/oauth2/server/authorization/authentication/OAuth2RefreshTokenAuthenticationProvider.java
Show resolved
Hide resolved
...ty/oauth2/server/authorization/authentication/OAuth2RefreshTokenAuthenticationTokenTest.java
Outdated
Show resolved
Hide resolved
...oauth2/server/authorization/authentication/OAuth2RefreshTokenAuthenticationProviderTest.java
Outdated
Show resolved
Hide resolved
...oauth2/server/authorization/authentication/OAuth2RefreshTokenAuthenticationProviderTest.java
Outdated
Show resolved
Hide resolved
...oauth2/server/authorization/authentication/OAuth2RefreshTokenAuthenticationProviderTest.java
Outdated
Show resolved
Hide resolved
...oauth2/server/authorization/authentication/OAuth2RefreshTokenAuthenticationProviderTest.java
Outdated
Show resolved
Hide resolved
ed9a404
to
37da4b2
Compare
Thanks for review @jgrandja, I think I addressed all your comments now. Also to recap what we discussed privately: |
Thanks for all the updates @alek-sys ! This is now in master. |
Just a draft for now, to run tests and discuss implementation.