Add code challenge methods for oidc provider configuration response #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
reviewed
Aug 16, 2023
| @@ -111,7 +111,8 @@ protected void doFilterInternal(HttpServletRequest request, HttpServletResponse | |||
| .tokenIntrospectionEndpointAuthenticationMethods(clientAuthenticationMethods()) | |||
| .subjectType("public") | |||
| .idTokenSigningAlgorithm(SignatureAlgorithm.RS256.getName()) | |||
| .scope(OidcScopes.OPENID); | |||
| .scope(OidcScopes.OPENID) | |||
| .codeChallengeMethod("S256"); | |||
There was a problem hiding this comment.
@drunkcattt Can you please update the test in OidcProviderConfigurationEndpointFilterTests similar to OAuth2AuthorizationServerMetadataEndpointFilterTests.
There was a problem hiding this comment.
@drunkcattt Are you able to update the test in OidcProviderConfigurationEndpointFilterTests?
jgrandja
added
status: duplicate
jgrandja
changed the title
drunkcattt
force-pushed
the
feat/add_s256_for_oidc_wellknow_endpoint
branch
2 times, most recently
from
103b97f to
dc892d8
Compare
drunkcattt
force-pushed
the
feat/add_s256_for_oidc_wellknow_endpoint
branch
from
dc892d8 to
1963092
Compare
jgrandja
changed the title
|
Thanks for the PR @drunkcattt. This is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code challenge method for oidc well-known configuration endpoint.
Closes gh-1302