Skip to content

Add authenticationDetailsSource to OAuth2TokenRevocationEndpointFilter #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

sealte
Copy link
Contributor

@sealte sealte commented Jul 9, 2024

Add authenticationDetailsSource to OAuth2TokenRevocationEndpointFilter

Closes gh-1634

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 9, 2024
Copy link
Collaborator

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sealte !

Please see the review comments.

After you apply the changes, we should be able to merge.

@jgrandja jgrandja self-assigned this Jul 15, 2024
@jgrandja jgrandja added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 15, 2024
@jgrandja jgrandja added this to the 1.4.0-M1 milestone Jul 15, 2024
sealte added 2 commits July 16, 2024 10:41
…ationAuthentication NOT the tokenRevocationAuthenticationResult; Add @SInCE 1.4
@sealte sealte requested a review from jgrandja July 19, 2024 01:19
jgrandja added a commit that referenced this pull request Jul 19, 2024
@jgrandja
Copy link
Collaborator

Thanks for the updates @sealte. This is now merged.

FYI, there were checkstyle errors so I added a polish commit to pass the build.

@jgrandja jgrandja closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configurable authenticationDetailsSource in OAuth2TokenRevocationEndpointFilter
3 participants