Fix to return client_secret_expires_at in client registration response#2134
Fix to return client_secret_expires_at in client registration response#2134wheleph wants to merge 2 commits intospring-projects:mainfrom
Conversation
Closes spring-projectsgh-2111 Signed-off-by: wheleph <wheleph@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
wheleph
changed the title
|
@jgrandja please have a look at the change. Looking forward to your feedback :) |
|
Thanks @wheleph. I have a couple of high priority tasks that I'm currently working on so I just wanted to let you know that I will review this soon. |
jgrandja
added
type: enhancement
|
I appreciate your transparency. No worries, take your time :) |
jgrandja
changed the title
jgrandja
changed the title
|
|
||
| OidcClientRegistration clientRegistrationResponse = registerClient(clientRegistration); | ||
|
|
||
| var expectedSecretExpiryDate = Instant.now().plus(Duration.ofHours(24)); |
There was a problem hiding this comment.
This project does not make use of var so to keep things consistent please use the type
| @EnableWebSecurity | ||
| @Configuration(proxyBeanMethods = false) | ||
| static class CustomClientMetadataConfiguration extends AuthorizationServerConfiguration { | ||
| static class CustomClientMetadataConfiguration extends ClientRegistrationConvertersConfiguration { |
There was a problem hiding this comment.
I appreciate taking advantage of reuse but there are too many changes applied to other tests and the preference is to isolate the changes to only the issue at hand. Also, I am totally ok with code duplication in tests and keeping things isolated. Please revert all unrelated changes and isolate to only the issue at hand.
Signed-off-by: wheleph <wheleph@gmail.com>
|
@jgrandja I've applied your suggestions. Please have a look and let me know if you have any other concerns |
jgrandja
changed the title
|
Thanks for the updates @wheleph. This is now merged along with a minor polish commit. |
3 participants
Closes gh-2111