Skip to content

WIP for feedback: Prototype to remember user consent decisions #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joshuatcasey
Copy link
Contributor

A user scope consent decisions can have a lifecycle outside of the context of an authorization code grant. For example, if a user user grants scope message.read to client message-client, this consent decision could live for 7 days, or 30 days, or be revokable by the user.

This is only a prototype to indicate how this might fit in with the current flow of OAuth2AuthorizationEndpointFilter.

TODO:

  • Remove any extraneous lines (such as imports that were moved accidentally)
  • Provide a sample HttpSession-based implementation of UserConsentRepository
  • Needs tests!
  • UserConsentRepository should be a bean that's injected via context, not created inside of OAuth2AuthorizationEndpointFilter
  • Note that the consent lookups use subject and clientId. Right now subject is the name of the principal, but this is really not a long-term solution. Authentication could be delegated to multiple upstream identity providers, each of which returns the same name for the principal. clientId also has problems, for example if that client is deleted, all of the consent decisions related to that client should be revoked else a new client with the same clientId will inherit those consent decisions.

Helpful feedback appreciated!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 5, 2021
@joshuatcasey joshuatcasey force-pushed the feature/remember-user-consents-#176580135 branch from 4020c65 to 6f92c61 Compare March 15, 2021 20:06
@jgrandja
Copy link
Collaborator

jgrandja commented Apr 27, 2021

@joshuatcasey As discussed with the team, I'll close this in favour of gh-280

@jgrandja jgrandja closed this Apr 27, 2021
@jgrandja jgrandja self-assigned this Apr 27, 2021
@jgrandja jgrandja added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 27, 2021
@Kehrlann Kehrlann deleted the feature/remember-user-consents-#176580135 branch June 23, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants