WIP for feedback: Prototype to remember user consent decisions #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user scope consent decisions can have a lifecycle outside of the context of an authorization code grant. For example, if a user
user
grants scopemessage.read
to clientmessage-client
, this consent decision could live for 7 days, or 30 days, or be revokable by the user.This is only a prototype to indicate how this might fit in with the current flow of
OAuth2AuthorizationEndpointFilter
.TODO:
imports
that were moved accidentally)HttpSession
-based implementation ofUserConsentRepository
UserConsentRepository
should be a bean that's injected via context, not created inside ofOAuth2AuthorizationEndpointFilter
subject
andclientId
. Right nowsubject
is the name of the principal, but this is really not a long-term solution. Authentication could be delegated to multiple upstream identity providers, each of which returns the same name for the principal.clientId
also has problems, for example if that client is deleted, all of the consent decisions related to that client should be revoked else a new client with the sameclientId
will inherit those consent decisions.Helpful feedback appreciated!