Skip to content

Add Core Model / Components in ref doc #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Core Model / Components in ref doc #714

wants to merge 1 commit into from

Conversation

jgrandja
Copy link
Collaborator

@jgrandja jgrandja commented May 2, 2022

Closes gh-671

@jgrandja jgrandja self-assigned this May 2, 2022
@jgrandja jgrandja added status: duplicate A duplicate of another issue type: enhancement A general enhancement labels May 2, 2022
@jgrandja jgrandja added this to the 0.3.0 milestone May 2, 2022
@jgrandja jgrandja requested a review from sjohnr May 2, 2022 17:30
Buzzardo
Buzzardo suggested changes May 2, 2022
View reviewed changes
sjohnr
sjohnr reviewed May 2, 2022
View reviewed changes
Copy link
Contributor

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, @jgrandja! I've added a couple of questions that could lead to improvements.

@Buzzardo, I can take the comments on the how-to-jpa.adoc and put them in a separate PR if @jgrandja agrees.

@Buzzardo
Copy link

Buzzardo commented May 2, 2022

@Buzzardo, I can take the comments on the how-to-jpa.adoc and put them in a separate PR if @jgrandja agrees.

Fine by me, so long as it works for you folks.

sjohnr pushed a commit that referenced this pull request May 3, 2022
Polish "How-to: Implement core services with JPA"
3cc89f9 
Issue gh-690
Issue gh-714
@sjohnr sjohnr closed this May 3, 2022
@jgrandja jgrandja deleted the gh-671-core-model-components branch May 3, 2022 18:43
jgrandja added a commit that referenced this pull request May 4, 2022
@jgrandja
Polish OAuth2TokenCustomizer in ref doc
6b0c2e3 
Issue gh-714
doba16 pushed a commit to doba16/spring-authorization-server that referenced this pull request Apr 21, 2023
Polish "How-to: Implement core services with JPA"
b00ac5f 
Issue spring-projectsgh-690
Issue spring-projectsgh-714
doba16 pushed a commit to doba16/spring-authorization-server that referenced this pull request Apr 21, 2023
@jgrandja
Polish OAuth2TokenCustomizer in ref doc
81e8c74 
Issue spring-projectsgh-714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjohnr sjohnr sjohnr left review comments

@Buzzardo Buzzardo Buzzardo requested changes

Assignees

@jgrandja jgrandja

Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

ref-doc: Document Core Model / Components
3 participants
@jgrandja @Buzzardo @sjohnr