Authorization Code generation in Authorization Endpoint Filter #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functionality Covered ------------------------- - Validation of client id & response type - Generate authorization code - Save Authorization - Redirect to client redirect uri - Send error in http response - Send error as query params in redirect uri Validations covered ------------------- - Client Id should be mandatory - Client Id should be registered - Client Id should be configured with Authorization grant type - Response type is mandaotry - Response type should be code
- On successfull redirect code was not being sent in the Redirect URL - validations methods were private, so made them protected
- Adding key constants for issues time and code used flag in OAuth2Authorization - Changing error code when Authorization grant is not supported by client - Change in error method for Unauthorized client - Corrected the validation for AuthorizationGrantType check - Adding attributes Issue time and Code use flag in attributes map - Adding state to redirect uri for both success and failure - Changing method name from get to set as it was wrongly used - Adding a basic test class which will be enhanced more
- Added a UUID based Authorization Code generator - Added an Ant Path request matcher to check endpoint validity - Added a new OAuth2 authorization request converter - Use DefaultRedirectStrategy from Spring - Added a check for user authentication present and authenticated - Added check for respone type parameter validity in request - Added check for redirect uri validity in request - Replaced StringBuilder with UriComponentsBuilder - Added JUnit tests for validation in section 4.1.1 of the RFC specs - Added a class which will be responsible for holding sever level messages as constants
Functionality Covered ------------------------- - Validation of client id & response type - Generate authorization code - Save Authorization - Redirect to client redirect uri - Send error in http response - Send error as query params in redirect uri Validations covered ------------------- - Client Id should be mandatory - Client Id should be registered - Client Id should be configured with Authorization grant type - Response type is mandaotry - Response type should be code
- On successfull redirect code was not being sent in the Redirect URL - validations methods were private, so made them protected
- Adding key constants for issues time and code used flag in OAuth2Authorization - Changing error code when Authorization grant is not supported by client - Change in error method for Unauthorized client - Corrected the validation for AuthorizationGrantType check - Adding attributes Issue time and Code use flag in attributes map - Adding state to redirect uri for both success and failure - Changing method name from get to set as it was wrongly used - Adding a basic test class which will be enhanced more
- Added a UUID based Authorization Code generator - Added an Ant Path request matcher to check endpoint validity - Added a new OAuth2 authorization request converter - Use DefaultRedirectStrategy from Spring - Added a check for user authentication present and authenticated - Added check for respone type parameter validity in request - Added check for redirect uri validity in request - Replaced StringBuilder with UriComponentsBuilder - Added JUnit tests for validation in section 4.1.1 of the RFC specs - Added a class which will be responsible for holding sever level messages as constants
- Added space after commans where ever applicable - Removed trailing whilte spaces - Added white space after if condition - Added headers before package declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
Functionality Covered
Validations covered