Fix parsing of the stop element in step XML
#4714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, users were forced to set the attribute `exit-code` of the element to `""` as a work-around to prevent failing restarts.
hpoettker
force-pushed
the
fix-stop-in-batch-xsd-3
branch
from
4672f58 to
ec661aa
Compare
|
Thank you for fixing this! I remember I worked on a reproducer (as you might have seen in the original issue), but I've never got the chance to fix the issue (or more precisely, to prioritize the issue). Rebased and merged as 39c593e. Thanks again for all your contributions! Really appreciated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1287.
Previously, users were forced to set the attribute
exit-codeof thestopelement to""as a work-around in some cases as the default valueSTOPPINGor any non-null value ofexit-codewould lead to failing job restarts.