Added @Nullable annotation to overriding methods. #726
Conversation
Resolves BATCH-2839
| @@ -102,6 +103,7 @@ protected void doExecute(StepExecution stepExecution) throws Exception { | |||
| /* (non-Javadoc) | |||
| * @see org.springframework.batch.core.step.StepLocator#getStep(java.lang.String) | |||
| */ | |||
| @Nullable | |||
There was a problem hiding this comment.
This @Nullable here does not make sense as the implementation throws NoSuchStepException when no step is found with the given name. The issue is that the behaviour is not consistent across the framework: some implementations return null (like SimpleJob) and some others throw NoSuchStepException like in here. I believe it is the contract StepLocator#getStep that should be fixed to throw an exception instead of returning null (in order to make it consistent with JobLocator), but my concern is that it would be a breaking change.
There was a problem hiding this comment.
Yes, you are right. Thanks for the changes.
| @@ -189,7 +191,8 @@ protected T doRead() throws Exception { | |||
| /** | |||
| * @return next line (skip comments).getCurrentResource | |||
| */ | |||
| private String readLine() { | |||
| @Nullable | |||
| protected String readLine() { | |||
There was a problem hiding this comment.
The visibility of readLine has been changed from private to protected. Why is that?
There was a problem hiding this comment.
Fixed in 2306141 as I believe this should not change.
There was a problem hiding this comment.
It was done for my internal tests. Thanks for the change.
|
@mikeldpl Could you please update the year in the license headers of the changed files? Thank you upfront. |
Resolves BATCH-2839