Skip to content

Add Kafka health indicator #11435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
behrangsa opened this issue Dec 27, 2017 · 4 comments
Closed

Add Kafka health indicator #11435

behrangsa opened this issue Dec 27, 2017 · 4 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@behrangsa
Copy link

Implement a Kafka health indicator. Something similar to org.springframework.boot.actuate.amqp.RabbitHealthIndicator.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 27, 2017
@snicoll
Copy link
Member

snicoll commented Dec 27, 2017

Would you mind contributing a PR?

@snicoll snicoll changed the title Feature request: Actuator KafkaHealthIndicator Add Kafka health indicator Dec 27, 2017
@snicoll snicoll added priority: normal status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 27, 2017
@Jcamilorada
Copy link
Contributor

@snicoll I would like to give a try.

About help monitoring do you think we can use metric producer metrics or health scenario need to include produce and consume of health message?

@snicoll
Copy link
Member

snicoll commented Jan 3, 2018

@Jcamilorada let's go with something basic first ("is Kafka up?"). We can refine later. Thanks!

Jcamilorada added a commit to Jcamilorada/spring-boot that referenced this issue Jan 5, 2018
@Jcamilorada
spring-projectsGH-11435: Add Kafka health indicator
0d0f643 
 - added kafka health indicator
 - added kafka health inidicator auto-configuration
Jcamilorada added a commit to Jcamilorada/spring-boot that referenced this issue Jan 5, 2018
@Jcamilorada
spring-projectsGH-11435: Add Kafka health indicator
e5c3c3f 
 - fixed typo
Jcamilorada added a commit to Jcamilorada/spring-boot that referenced this issue Jan 5, 2018
@Jcamilorada
spring-projectsGH-11435: Add Kafka health indicator
2a1cb28 
 - code review changes
@Jcamilorada Jcamilorada mentioned this issue Jan 5, 2018
Closed
@snicoll
Copy link
Member

snicoll commented Jan 5, 2018

Closing in favour of PR #11515

@snicoll snicoll closed this as completed Jan 5, 2018
@snicoll snicoll added status: duplicate A duplicate of another issue and removed priority: normal status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement labels Jan 5, 2018
@Jcamilorada Jcamilorada mentioned this issue Jan 5, 2018
Closed
Jcamilorada added a commit to Jcamilorada/spring-boot that referenced this issue Jan 8, 2018
@Jcamilorada
spring-projectsGH-11435: Add Kafka health indicator
c0510f7 
- refactor code to create and destroy admin client when health monitoring
Jcamilorada added a commit to Jcamilorada/spring-boot that referenced this issue Feb 1, 2018
@Jcamilorada
spring-projectsGH-11435: Add Kafka health indicator
5ce8112 
 - added support for replication factor
Jcamilorada added a commit to Jcamilorada/spring-boot that referenced this issue Feb 1, 2018
@Jcamilorada
Merge remote-tracking branch 'upstream/master' into spring-projectsGH…
4468cb8 
…-11435
Jcamilorada added a commit to Jcamilorada/spring-boot that referenced this issue Feb 1, 2018
@Jcamilorada
spring-projectsGH-11435: Add Kafka health indicator
7a98dc5 
 - fixed coding style
snicoll added a commit that referenced this issue Feb 8, 2018
@snicoll
Merge pull request #11515 from Jcamilorada:GH-11435
c1d7d5e 
* pr/11515:
  Polish "Add Kafka health indicator"
  Add Kafka health indicator
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed status: duplicate A duplicate of another issue labels Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@behrangsa @snicoll @philwebb @Jcamilorada @spring-projects-issues