Skip to content

Update data properties to make it clear which stores do and do not require Spring Data #11574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbhave opened this issue Jan 8, 2018 · 4 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@mbhave
Copy link
Contributor

mbhave commented Jan 8, 2018

Redis properties are under spring.redis currently. This seems to be inconsistent with other stores that have properties under spring.data (eg, couchbase, cassandra, neo4j).

@mbhave mbhave added the for: team-attention An issue we'd like other members of the team to review label Jan 8, 2018
@philwebb
Copy link
Member

philwebb commented Jan 8, 2018

For java packages we have a split for some technologies. For example, the org.springframework.boot.autoconfigure.mongo package contains no Spring Data bits those are only in org.springframework.boot.autoconfigure.data.mongo.

@snicoll
Copy link
Member

snicoll commented Jan 9, 2018

Redis is a different beast in the sense that even the low-level connection stuff relies on Spring Data. In that sense the package is ok (since there is a dependency on Spring Data.

There is no reason however to bring the data part in the namespace since those keys aren't related to the Spring Data part.

I am not saying the situation is perfectly fine (I am sure we can find inconsistencies easily) but this one looks ok to me.

@philwebb philwebb changed the title Review RedisProperties Review all data properties Jan 10, 2018
@philwebb
Copy link
Member

There's a lot of inconsistency with all our data properties. We should expand the scope of this to look at them all.

@snicoll
Copy link
Member

snicoll commented May 12, 2020

Note that the package structure also affects the actuator. We don't have any data package at all there and a number of support classes are effectively Spring Data specific. The current health indicator for Cassandra is a good example.

@philwebb philwebb modified the milestones: 2.x, 3.0.x May 4, 2022
@mbhave mbhave self-assigned this May 5, 2022
@mbhave mbhave added the for: team-meeting An issue we'd like to discuss as a team to make progress label Jul 26, 2022
@bclozel bclozel removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Jul 27, 2022
@mbhave mbhave closed this as completed in 0991bd3 Aug 5, 2022
@mbhave mbhave modified the milestones: 3.0.x, 3.0.0-M5 Aug 5, 2022
mbhave added a commit that referenced this issue Aug 5, 2022
@wilkinsona wilkinsona changed the title Review all data properties Update data properties to make it clear which stores do and do not require Spring Data Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants