Skip to content

Use deterministic order for configuration properties metadata #14347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Sep 7, 2018 · 0 comments
Closed

Use deterministic order for configuration properties metadata #14347

snicoll opened this issue Sep 7, 2018 · 0 comments
Assignees
@snicoll
Labels
type: enhancement A general enhancement
Milestone
2.1.0.M3

Comments

@snicoll
Copy link
Member

snicoll commented Sep 7, 2018

Rather than writing the metadata in a non deterministic order, it would be preferable to write it in such a way that entries are ordered alphabetically.

Some tools use a find first matching strategy. As such, pushing deprecated items to the bottom would be a cheap way to make sure they consider deprecated items last.
@snicoll snicoll added the type: enhancement A general enhancement label Sep 7, 2018
@snicoll snicoll self-assigned this Sep 8, 2018
@snicoll snicoll added this to the 2.1.0.M3 milestone Sep 8, 2018
@snicoll snicoll closed this as completed in 0493355 Sep 8, 2018
davidkarlsen pushed a commit to davidkarlsen/spring-boot that referenced this issue Sep 8, 2018
@snicoll @davidkarlsen
Use deterministic order for configuration properties metadata
b2d7c24 
This commit updates the annotation processor to write metadata in a
consistent way. Groups, properties and hints are written and each item
is ordered alphabetically based on its name.

Also, deprecated items are written last.

Closes spring-projectsgh-14347

Signed-off-by: David J. M. Karlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.1.0.M3
Development

No branches or pull requests
1 participant
@snicoll