Skip to content

Add support for reactor-tools #17128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bclozel opened this issue Jun 12, 2019 · 0 comments
Closed

Add support for reactor-tools #17128

bclozel opened this issue Jun 12, 2019 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Jun 12, 2019

After chatting with the reactor team, it seems that the Hooks.onOperatorDebug() is going away and soon to be replaced by reactor-tools support, with a few differences:

  • reactor-tools is a separate dependency, adds debugging support with bytecode (vs. AOP-like with operators)
  • reactor-tools is generally supported (for development and production), but might not be widely compatible with all JVMs right now

With that in mind, we should not add reactor-tools as a dependency to existing starters, as this should be a conscious choice by developers to include it.

We should, if on the classpath, enable automatically the reactor-tools agent. We need to provide a configuration property to disable it in case developers need an "escape hatch".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant