Skip to content

Upgrade to REST Assured 4.2.1 #22303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asaikali opened this issue Jul 10, 2020 · 10 comments
Closed

Upgrade to REST Assured 4.2.1 #22303

asaikali opened this issue Jul 10, 2020 · 10 comments
Assignees
Labels
status: superseded An issue that has been superseded by another type: dependency-upgrade A dependency upgrade

Comments

@asaikali
Copy link

asaikali commented Jul 10, 2020

REST Assured is currently at version 4.3.x spring default is 3.3. Rest Assured 3.3 uses an older version groovy that generates warning from Java 11 about illegal access that will be discounted in a future JDK version. REST assured 4.3 upgrades groovy to 3.0.3 which fixes these JDK compatibility issues. Please consider adding support for the 4.x series of REST Assured. This might depend on

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 10, 2020
@wilkinsona
Copy link
Member

Thanks, @asaikali. FWIW, the version of Groovy that REST Assured shouldn't matter as it'll be overridden by Spring Boot's dependency management. As far as we know, the 2.5.x version of Groovy that Spring Boot uses by default works fine on Java 11.

@asaikali
Copy link
Author

It's working just fine on Java 11 I just see a lot the warning below in my logs.

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/Users/adib/.gradle/caches/modules-2/files-2.1/org.codehaus.groovy/groovy/2.5.12/c5a65ece40ef0030e6958af990bd6d83b4e206ec/groovy-2.5.12.jar) to method java.lang.reflect.AnnotatedElement.lambda$getDeclaredAnnotationsByType$0(java.lang.annotation.Annotation,java.lang.annotation.Annotation)
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

@philwebb philwebb added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 10, 2020
@philwebb philwebb added this to the 2.x milestone Jul 10, 2020
@philwebb philwebb added the status: blocked An issue that's blocked on an external project change label Jul 10, 2020
@asaikali
Copy link
Author

FYI I don't use groovy in my app, I am on boot 2.3. I have been able to override the boot defaults to Groovy 3.0.4 and RestAssured 4.3.1 everything seems to be working fine all my tests are passing. RestDocs looks like it's working on with RestAssured 4.3.1

@hennr
Copy link

hennr commented Dec 2, 2020

Hi @philwebb ,

can you give us a idea why you put this ticket into blocked?
Thanks in advance!

@wilkinsona
Copy link
Member

wilkinsona commented Dec 7, 2020

@hennr I believe the comments above yours answer that question. The big one is that REST Assured 4.3 uses Groovy 3.0.x while Boot is still using Groovy 2.5.x at this time. The upgrade to Groovy 3.0 is blocked as there is no Groovy 3.0-compatible GA of Spock at this time.

@chadlwilson
Copy link

Is it a possibility for us to get to rest-assured 4.2 earlier than 4.3 to reduce the delta we are running with? We have been running locally with 4.2 dependency overrides (no Groovy change) without noticing any issues. Haven't run it through all the boot regression suites; so treat as anecdotal.

I believe it might be possible to decouple broad4.x compatibility from 4.3 compatibility (which does indeed involve the aforementioned Groovy upgrade issues)

@hennr
Copy link

hennr commented Dec 9, 2020

@hennr I believe the comments above yours answer that question. The big one is that REST Assured 4.3 uses Groovy 3.0.x while Boot is still using Groovy 2.5.x at this time. The upgrade to Groovy 3.0 is blocked as there is no Groovy 3.0-compatible GA of Spock at this time.

Thanks for clarifiying this, @wilkinsona

Is it a possibility for us to get to rest-assured 4.2 earlier than 4.3 to reduce the delta we are running with? We have been running locally with 4.2 dependency overrides (no Groovy change) without noticing any issues. Haven't run it through all the boot regression suites; so treat as anecdotal.
I believe it might be possible to decouple broad4.x compatibility from 4.3 compatibility (which does indeed involve the aforementioned Groovy upgrade issues)

I like this suggestion by @chadlwilson a lot, is there a chance to go this way?

@wilkinsona
Copy link
Member

Yes, I think so. Spring REST Docs is compatible with REST Assured 4.x so it's just the Groovy dependency that's holding this back. 4.2.0 uses Groovy 2.5.x so we should be able to upgrade to that in Boot 2.5.

@wilkinsona wilkinsona changed the title Support REST Assured 4 Upgrade to REST Assured 4.2.0 Dec 9, 2020
@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Dec 9, 2020
@wilkinsona wilkinsona modified the milestones: 2.x, 2.5.x Dec 9, 2020
@hennr
Copy link

hennr commented Dec 10, 2020

That's good news, thanks everyone!

@wilkinsona wilkinsona changed the title Upgrade to REST Assured 4.2.0 Upgrade to REST Assured 4.2.1 Dec 11, 2020
@snicoll snicoll modified the milestones: 2.5.x, 2.5.0-M1 Dec 23, 2020
@snicoll snicoll self-assigned this Dec 23, 2020
wilkinsona added a commit that referenced this issue Jan 19, 2021
REST Assured 4.3.x requires Groovy 3 that we can't yet upgrade to as
there is no compatibile GA of Spock.

This commit prohibits upgrades to 4.3 so that Bomr ignores the possible
upgrade.

See gh-22303
@wilkinsona
Copy link
Member

Superseded by #24962.

@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Jan 21, 2021
@wilkinsona wilkinsona removed this from the 2.5.0-M1 milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

7 participants