-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Upgrade to REST Assured 4.2.1 #22303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks, @asaikali. FWIW, the version of Groovy that REST Assured shouldn't matter as it'll be overridden by Spring Boot's dependency management. As far as we know, the 2.5.x version of Groovy that Spring Boot uses by default works fine on Java 11. |
It's working just fine on Java 11 I just see a lot the warning below in my logs.
|
FYI I don't use groovy in my app, I am on boot 2.3. I have been able to override the boot defaults to Groovy 3.0.4 and RestAssured 4.3.1 everything seems to be working fine all my tests are passing. RestDocs looks like it's working on with RestAssured 4.3.1 |
Hi @philwebb , can you give us a idea why you put this ticket into blocked? |
@hennr I believe the comments above yours answer that question. The big one is that REST Assured 4.3 uses Groovy 3.0.x while Boot is still using Groovy 2.5.x at this time. The upgrade to Groovy 3.0 is blocked as there is no Groovy 3.0-compatible GA of Spock at this time. |
Is it a possibility for us to get to rest-assured I believe it might be possible to decouple broad |
Thanks for clarifiying this, @wilkinsona
I like this suggestion by @chadlwilson a lot, is there a chance to go this way? |
Yes, I think so. Spring REST Docs is compatible with REST Assured 4.x so it's just the Groovy dependency that's holding this back. 4.2.0 uses Groovy 2.5.x so we should be able to upgrade to that in Boot 2.5. |
That's good news, thanks everyone! |
REST Assured 4.3.x requires Groovy 3 that we can't yet upgrade to as there is no compatibile GA of Spock. This commit prohibits upgrades to 4.3 so that Bomr ignores the possible upgrade. See gh-22303
Superseded by #24962. |
REST Assured is currently at version 4.3.x spring default is 3.3. Rest Assured 3.3 uses an older version groovy that generates warning from Java 11 about illegal access that will be discounted in a future JDK version. REST assured 4.3 upgrades groovy to 3.0.3 which fixes these JDK compatibility issues. Please consider adding support for the 4.x series of REST Assured. This might depend on
The text was updated successfully, but these errors were encountered: