Skip to content

Reinstate smoketest.rsocket.SampleRSocketApplicationTests.rSocketEndpoint() #22725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Aug 4, 2020 · 3 comments
Closed

Reinstate smoketest.rsocket.SampleRSocketApplicationTests.rSocketEndpoint() #22725

wilkinsona opened this issue Aug 4, 2020 · 3 comments
Labels
status: superseded An issue that has been superseded by another type: task A general task

Comments

@wilkinsona
Copy link
Member

It fails at the moment:

java.lang.AssertionError: expectation "assertNext" failed (expected: onNext(); actual: onError(ConnectionErrorException (0x101): Unexpected error during frame handling))
	at reactor.test.MessageFormatter.assertionError(MessageFormatter.java:115)
	at reactor.test.MessageFormatter.failPrefix(MessageFormatter.java:104)
	at reactor.test.MessageFormatter.fail(MessageFormatter.java:73)
	at reactor.test.MessageFormatter.failOptional(MessageFormatter.java:88)
	at reactor.test.DefaultStepVerifierBuilder.lambda$consumeNextWith$1(DefaultStepVerifierBuilder.java:268)
	at reactor.test.DefaultStepVerifierBuilder$SignalEvent.test(DefaultStepVerifierBuilder.java:2213)
	at reactor.test.DefaultStepVerifierBuilder$DefaultVerifySubscriber.onSignal(DefaultStepVerifierBuilder.java:1485)
	at reactor.test.DefaultStepVerifierBuilder$DefaultVerifySubscriber.onExpectation(DefaultStepVerifierBuilder.java:1433)
	at reactor.test.DefaultStepVerifierBuilder$DefaultVerifySubscriber.onError(DefaultStepVerifierBuilder.java:1092)
	at reactor.core.publisher.FluxMap$MapSubscriber.onError(FluxMap.java:132)
	at reactor.core.publisher.FluxMap$MapSubscriber.onError(FluxMap.java:132)
	at io.rsocket.core.ResolvingOperator$DeferredResolution.onError(ResolvingOperator.java:476)
	at io.rsocket.core.RequestResponseRequesterMono.handleError(RequestResponseRequesterMono.java:245)
	at io.rsocket.core.RSocketRequester.lambda$terminate$4(RSocketRequester.java:343)
	at java.lang.Iterable.forEach(Iterable.java:75)
	at io.rsocket.core.RSocketRequester.terminate(RSocketRequester.java:340)
	at io.rsocket.core.RSocketRequester.tryTerminate(RSocketRequester.java:317)
	at io.rsocket.core.RSocketRequester.tryTerminateOnZeroError(RSocketRequester.java:310)
	at io.rsocket.core.RSocketRequester.handleStreamZero(RSocketRequester.java:221)
	at io.rsocket.core.RSocketRequester.handleIncomingFrames(RSocketRequester.java:203)
	at reactor.core.publisher.LambdaSubscriber.onNext(LambdaSubscriber.java:160)
	at reactor.core.publisher.MonoFlatMapMany$FlatMapManyInner.onNext(MonoFlatMapMany.java:250)
	at reactor.core.publisher.FluxGroupBy$UnicastGroupedFlux.drainRegular(FluxGroupBy.java:561)
	at reactor.core.publisher.FluxGroupBy$UnicastGroupedFlux.drain(FluxGroupBy.java:637)
	at reactor.core.publisher.FluxGroupBy$UnicastGroupedFlux.subscribe(FluxGroupBy.java:703)
	at reactor.core.publisher.Flux.subscribe(Flux.java:7961)
	at reactor.core.publisher.MonoFlatMapMany$FlatMapManyMain.onNext(MonoFlatMapMany.java:195)
	at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1782)
	at reactor.core.publisher.MonoProcessor.onNext(MonoProcessor.java:317)
	at io.rsocket.internal.ClientServerInputMultiplexer.lambda$new$1(ClientServerInputMultiplexer.java:126)
	at reactor.core.publisher.LambdaSubscriber.onNext(LambdaSubscriber.java:160)
	at reactor.core.publisher.FluxGroupBy$GroupByMain.drainLoop(FluxGroupBy.java:387)
	at reactor.core.publisher.FluxGroupBy$GroupByMain.drain(FluxGroupBy.java:323)
	at reactor.core.publisher.FluxGroupBy$GroupByMain.onNext(FluxGroupBy.java:207)
	at reactor.core.publisher.FluxMap$MapSubscriber.onNext(FluxMap.java:120)
	at reactor.core.publisher.FluxMap$MapSubscriber.onNext(FluxMap.java:120)
	at reactor.netty.channel.FluxReceive.drainReceiver(FluxReceive.java:260)
	at reactor.netty.channel.FluxReceive.onInboundNext(FluxReceive.java:366)
	at reactor.netty.channel.ChannelOperations.onInboundNext(ChannelOperations.java:373)
	at reactor.netty.channel.ChannelOperationsHandler.channelRead(ChannelOperationsHandler.java:94)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:324)
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:296)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:163)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:714)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:650)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:576)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.lang.Thread.run(Thread.java:748)
	Suppressed: ConnectionErrorException (0x101): Unexpected error during frame handling
		at io.rsocket.exceptions.Exceptions.from(Exceptions.java:66)
		at io.rsocket.core.RSocketRequester.lambda$tryTerminateOnZeroError$3(RSocketRequester.java:310)
		at io.rsocket.core.RSocketRequester.tryTerminate(RSocketRequester.java:315)
		... 44 more

@rwinch is investigating the security side of things.
@wilkinsona wilkinsona added the type: task A general task label Aug 4, 2020
@wilkinsona wilkinsona added this to the 2.4.0-M2 milestone Aug 4, 2020
wilkinsona added a commit that referenced this issue Aug 4, 2020
@wilkinsona
Temporarily disable rSocketEndpoint test
9264f6a 
See gh-22725
@bclozel bclozel modified the milestones: 2.4.0-M2, 2.4.0-M3 Aug 7, 2020
@bclozel
Copy link
Member

bclozel commented Aug 7, 2020

This is blocked by spring-projects/spring-security#8948, I'm rescheduling this issue to the next milestone as a result.

@bclozel bclozel added the status: blocked An issue that's blocked on an external project change label Aug 7, 2020
@snicoll snicoll removed the status: blocked An issue that's blocked on an external project change label Sep 7, 2020
@bclozel bclozel added the status: blocked An issue that's blocked on an external project change label Sep 9, 2020
@bclozel
Copy link
Member

bclozel commented Sep 9, 2020

Waiting on #23225

dreis2211 added a commit to dreis2211/spring-boot that referenced this issue Sep 10, 2020
@dreis2211
Reinstate smoketest.rsocket.SampleRSocketApplicationTests.rSocketEndp…
5755df8 
…oint()

Closes spring-projectsgh-22725
@dreis2211 dreis2211 mentioned this issue Sep 10, 2020
Closed
@snicoll
Copy link
Member

snicoll commented Sep 17, 2020

Closing in favour of PR #23246

@snicoll snicoll closed this as completed Sep 17, 2020
@snicoll snicoll added status: superseded An issue that has been superseded by another and removed status: blocked An issue that's blocked on an external project change labels Sep 17, 2020
@snicoll snicoll removed this from the 2.4.0-M3 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reinstate SampleRSocketApplicationTests.rSocketEndpoint() dreis2211/spring-boot
3 participants
@bclozel @snicoll @wilkinsona