Skip to content

Fragility in AuthenticationManagerConfiguration #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Feb 10, 2015 · 1 comment
Closed

Fragility in AuthenticationManagerConfiguration #2474

rwinch opened this issue Feb 10, 2015 · 1 comment
Assignees
@rwinch
Labels
type: bug A general bug
Milestone
1.1.11

Comments

@rwinch
Copy link
Member

rwinch commented Feb 10, 2015

AuthenticationManagerConfiguration#isAuthenticationManagerAlreadyConfigured is quite fragile because it checks to see how many GlobalAuthenticationConfigurerAdapter there are. If more are added by the framework (i.e. #2473), then it won't work.

Additionally, it seems there is a bit of cleanup we can do in AuthenticationManagerConfiguration to make things a bit easier.
@rwinch rwinch self-assigned this Feb 10, 2015
@rwinch rwinch added this to the 1.1.11 milestone Feb 10, 2015
@rwinch rwinch added refactor type: bug A general bug labels Feb 10, 2015
rwinch pushed a commit to rwinch/spring-boot that referenced this issue Feb 10, 2015
Fix fragile AuthenticationManagerConfiguration
3695dde 
Fixes spring-projectsgh-2474
rwinch pushed a commit to rwinch/spring-boot that referenced this issue Feb 10, 2015
Fix fragile AuthenticationManagerConfiguration
7022bf4 
Fixes spring-projectsgh-2474
@rwinch
Copy link
Member Author

rwinch commented Feb 10, 2015

See #2475

@rwinch rwinch closed this as completed in e42fa79 Feb 18, 2015
wilkinsona added a commit that referenced this issue Feb 19, 2015
@wilkinsona
Backport to 1.1.x the fix for gh-2474 (originally made in e42fa79)
df81b31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
type: bug A general bug
Projects
None yet
Milestone
1.1.11
Development

No branches or pull requests
1 participant
@rwinch