Skip to content

Default servlet location is not registered using a ServletContextResource #24745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Jan 11, 2021 · 0 comments
Closed

Default servlet location is not registered using a ServletContextResource #24745

philwebb opened this issue Jan 11, 2021 · 0 comments
Labels
type: bug A general bug
Milestone
2.2.13

Comments

@philwebb
Copy link
Member

It would be better if we updated WebMvcAutoConfiguration to register the default SERVLET_LOCATIONS using a ServletContextResource to save a ResourceLoader call.
@philwebb philwebb added the type: enhancement A general enhancement label Jan 11, 2021
@philwebb philwebb added this to the 2.2.x milestone Jan 11, 2021
@philwebb philwebb mentioned this issue Jan 11, 2021
Closed
philwebb added a commit that referenced this issue Jan 12, 2021
@philwebb
Simplify resource registration
bd21c43 
Simplify resource registration by using the new Spring Framework API
that allows `Resource` instances to be registered directly.

See gh-24745
@philwebb philwebb modified the milestones: 2.2.x, 2.2.13 Jan 12, 2021
@philwebb philwebb changed the title Register default resource path using ServletContextResource Default servlet location is not registered using a ServletContextResource Jan 13, 2021
@philwebb philwebb added type: bug A general bug and removed type: enhancement A general enhancement labels Jan 13, 2021
@bclozel bclozel mentioned this issue Feb 12, 2021
Closed
humaolin pushed a commit to humaolin/spring-boot that referenced this issue May 7, 2022
@jhoeller
Thread-safe access to WebSocketServerFactory and WebSocketExtensions
f20027f 
Closes spring-projectsgh-24745
humaolin pushed a commit to humaolin/spring-boot that referenced this issue May 7, 2022
@jhoeller
Thread-safe access to WebSocketServerFactory and WebSocketExtensions
dbb0933 
Closes spring-projectsgh-24745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.2.13
Development

No branches or pull requests
1 participant
@philwebb