Skip to content

Incorrect detection of MariaDB #25127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks
lbruun opened this issue Feb 7, 2021 · 4 comments
Closed
4 tasks

Incorrect detection of MariaDB #25127

lbruun opened this issue Feb 7, 2021 · 4 comments
Assignees
Labels
status: first-timers-only An issue that can only be worked on by brand new contributors status: superseded An issue that has been superseded by another type: bug A general bug

Comments

@lbruun
Copy link

lbruun commented Feb 7, 2021

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general ideal-for-contribution issues. Thanks!

Problem

Detection of MariaDB in org.springframework.boot.jdbc.DataBaseDriver is incorrect. The MariaDB driver returns MariaDB as the productName but we are using MySQL as the productName.

Solution

Update the DatabaseDriver enum with the right value for the productName for MariaDB.

Update the tests to ensure that the right DatabaseDriver.fromProductName() works for MariaDB.

Steps to Fix

  • Claim this issue with a comment below and ask any clarifying questions you need
  • Set up a repository locally following the Contributing Guidelines
  • Try to fix the issue following the steps above
  • Commit your changes and start a pull request.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 7, 2021
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 8, 2021
@philwebb philwebb added this to the 2.3.x milestone Feb 8, 2021
@mbhave mbhave added the status: first-timers-only An issue that can only be worked on by brand new contributors label Feb 9, 2021
@anudeepg
Copy link
Contributor

I am interested to contribute, Can I claim this issue ?

@scottfrederick
Copy link
Contributor

@anudeepg I've assigned the issue to you. Please let us know if you have any questions. Note that the issue is assigned to the 2.3.x milestone, so you should submit a pull request against that branch. We'll take care of merging the changes forward to newer versions when merging the PR.

@anudeepg
Copy link
Contributor

Thanks for encouraging first-timers, I am just checking out code & following contribution guidelines.
Sure I will raise the PR accordingly.

@snicoll
Copy link
Member

snicoll commented Feb 11, 2021

Closing in favor of PR #25173

@snicoll snicoll closed this as completed Feb 11, 2021
@snicoll snicoll removed this from the 2.3.x milestone Feb 11, 2021
@snicoll snicoll added the status: superseded An issue that has been superseded by another label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: first-timers-only An issue that can only be worked on by brand new contributors status: superseded An issue that has been superseded by another type: bug A general bug
Projects
None yet
Development

No branches or pull requests

7 participants