-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Incorrect detection of Amazon Redshift #25128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@scottfrederick As I am fixing similar issue of MariaDB #25127 |
@anudeepg Thanks for the offer, but can we give someone else a chance to do this one. We're keen to get as many first-timers as possible. |
This comment has been minimized.
This comment has been minimized.
Sure, thanks for giving chance to first-timers. I will check any other issues if I can contribute. Do you have any suggestion for filtering issues which i (any new contributor but using spring from many years in Java projects) can look ? |
Hi @philwebb , Can I pick this one up if no one else is working on it? |
@melburne the issue is all yours, let us know if you have any questions. |
Closing in favor of PR #25265 |
Hi, this is a
first-timers-only
issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
If you have contributed before, consider leaving this one for someone new, and looking through our general
ideal-for-contribution
issues. Thanks!Problem
Detection of Amazon Redshift in org.springframework.boot.jdbc.DataBaseDriver is incorrect. The Redshift JDBC driver returns
Redshift
as theproductName
but we are usingAmazon Redshift
as theproductName
.Solution
Update the
DatabaseDriver
enum with the right value for theproductName
forRedshift
.Update the tests to ensure that the right
DatabaseDriver.fromProductName()
works forRedshift
.Steps to Fix
The text was updated successfully, but these errors were encountered: