Skip to content

JooqExceptionTranslator passes null exception to jOOQ when SQLException cannot be translated #25717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Mar 17, 2021 · 0 comments
Closed

JooqExceptionTranslator passes null exception to jOOQ when SQLException cannot be translated #25717

wilkinsona opened this issue Mar 17, 2021 · 0 comments
Assignees
@wilkinsona
Labels
type: bug A general bug
Milestone
2.4.4

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Mar 17, 2021 •
edited
Loading

Rather than calling ExecuteContext(RuntimeException) with null, we shouldn't call jOOQ at all. This will lead to throwing the original SQLException wrapped in a jOOQ DataAccessException, just as if the JooqExceptionTranslator hadn't been configured.

See #25493 for further details.
@wilkinsona wilkinsona added the type: bug A general bug label Mar 17, 2021
@wilkinsona wilkinsona added this to the 2.4.4 milestone Mar 17, 2021
@wilkinsona wilkinsona self-assigned this Mar 17, 2021
This was referenced Mar 17, 2021
Closed
Closed
This was referenced Mar 18, 2021
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
sgrimm added a commit to terraware/terraware-server that referenced this issue Dec 15, 2021
@sgrimm
Upgrade to Spring Boot 2.4.4
aeed6f6 
While developing the search code, it was annoying to keep running into
spring-projects/spring-boot#25717 which caused database
error messages to not show up in the logs. The bug was fixed in the patch version
of Spring Boot just after the one we were using.
@sgrimm sgrimm mentioned this issue Dec 15, 2021
Merged
kallen07 pushed a commit to terraware/terraware-server that referenced this issue Dec 15, 2021
@sgrimm
Upgrade to Spring Boot 2.4.4 (#141)
0f916c1 
While developing the search code, it was annoying to keep running into
spring-projects/spring-boot#25717 which caused database
error messages to not show up in the logs. The bug was fixed in the patch version
of Spring Boot just after the one we were using.
humaolin pushed a commit to humaolin/spring-boot that referenced this issue May 7, 2022
@jhoeller
Properties loading with ignoreResourceNotFound covers SocketException…
caa22b7 
… as well

Closes spring-projectsgh-25717
humaolin pushed a commit to humaolin/spring-boot that referenced this issue May 7, 2022
@jhoeller
Properties loading with ignoreResourceNotFound covers SocketException…
3632b8b 
… as well

Closes spring-projectsgh-25717

(cherry picked from commit 613b05d)
humaolin pushed a commit to humaolin/spring-boot that referenced this issue May 7, 2022
@jhoeller
Properties loading with ignoreResourceNotFound covers SocketException…
337d587 
… as well

Closes spring-projectsgh-25717

(cherry picked from commit 613b05d)
This was referenced Dec 7, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: bug A general bug
Projects
None yet
Milestone
2.4.4
Development

No branches or pull requests
1 participant
@wilkinsona