Skip to content

Cleanup Security Related Documentation & Samples #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwinch opened this issue Mar 3, 2015 · 13 comments
Closed

Cleanup Security Related Documentation & Samples #2589

rwinch opened this issue Mar 3, 2015 · 13 comments
Labels
status: duplicate A duplicate of another issue

Comments

@rwinch
Copy link
Member

rwinch commented Mar 3, 2015

For example, we do not need to use GlobalAuthenticationConfigurerAdapter in the following sample:

https://github.com/spring-projects/spring-boot/blob/master/spring-boot-samples/spring-boot-sample-web-method-security/src/main/java/sample/ui/method/SampleMethodSecurityApplication.java

Instead we can use @Autowired

@snicoll
Copy link
Member

snicoll commented Oct 14, 2015

@rwinch are you going to provide a PR for this? thanks.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Oct 14, 2015
@rwinch
Copy link
Member Author

rwinch commented Oct 14, 2015

@snicoll I am planning on it, but I'm a bit overwhelmed with other items.

@snicoll snicoll removed the status: waiting-for-feedback We need additional information before we can continue label Oct 14, 2015
@philwebb philwebb modified the milestones: 1.3.1, 1.3.0 Nov 13, 2015
@philwebb
Copy link
Member

Pushing back to 1.3.1. We'll have to live with it for now.

@philwebb philwebb modified the milestones: 1.3.2, 1.3.1 Dec 17, 2015
@philwebb
Copy link
Member

@rwinch If you've got a quick crib sheet of the changes needed I can update the docs. Not sure totally all the issues that are wrong at the moment.

@philwebb philwebb modified the milestones: 1.3.3, 1.3.2 Jan 21, 2016
@snicoll
Copy link
Member

snicoll commented Jan 27, 2016

ping @rwinch :)

@rwinch
Copy link
Member Author

rwinch commented Jan 27, 2016

@snicoll Thanks for the ping. I think the problem is that by the time I advise on how to do it I might as well have done it :) I will schedule some time on Friday to send a PR.

@rwinch
Copy link
Member Author

rwinch commented Jan 27, 2016

@philwebb - One thing I was wanting to (re-)ask is if we can enable no format tags in Spring Boot's Eclipse configuration? This would help make the source code more readable.

@philwebb
Copy link
Member

@rwinch I think it's already configured, we just don't use it. Feel free to try with them if you prefer.

wilkinsona added a commit to wilkinsona/spring-boot that referenced this issue Jan 28, 2016
@wilkinsona
Copy link
Member

@philwebb @rwinch They're switched off at the moment. I've tried turning them on (see wilkinsona@3f5a962). With these changes in place, and after doing Maven -> Update Project..., the configuration looks right in the Eclipse UI but the tags don't seem to be having any effect.

@philwebb
Copy link
Member

Hmm, OK. Perhaps we can continue with this one without that and raise a new issue if we feel strongly about disabling auto-formatting.

rwinch pushed a commit to rwinch/spring-boot that referenced this issue Jan 29, 2016
rwinch pushed a commit to rwinch/spring-boot that referenced this issue Jan 29, 2016
rwinch pushed a commit to rwinch/spring-boot that referenced this issue Jan 29, 2016
@rwinch
Copy link
Member Author

rwinch commented Jan 29, 2016

@snicoll @philwebb @wilkinsona I submitted a PR #5052 for your review

@philwebb philwebb modified the milestones: 1.3.4, 1.3.3 Feb 26, 2016
@philwebb
Copy link
Member

Pushing back to 1.3.4. See comments in PR

@snicoll snicoll modified the milestones: 1.3.4, 1.3.5, 1.3.6 May 6, 2016
@snicoll snicoll modified the milestones: 1.4.0, 1.3.6 Jun 17, 2016
@snicoll
Copy link
Member

snicoll commented Jul 13, 2016

duplicates #5052

@snicoll snicoll closed this as completed Jul 13, 2016
@snicoll snicoll added status: duplicate A duplicate of another issue and removed type: documentation A documentation update labels Jul 13, 2016
@snicoll snicoll removed this from the 1.4.0 milestone Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants