-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Cleanup Security Related Documentation & Samples #2589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@rwinch are you going to provide a PR for this? thanks. |
@snicoll I am planning on it, but I'm a bit overwhelmed with other items. |
Pushing back to 1.3.1. We'll have to live with it for now. |
@rwinch If you've got a quick crib sheet of the changes needed I can update the docs. Not sure totally all the issues that are wrong at the moment. |
ping @rwinch :) |
@snicoll Thanks for the ping. I think the problem is that by the time I advise on how to do it I might as well have done it :) I will schedule some time on Friday to send a PR. |
@philwebb - One thing I was wanting to (re-)ask is if we can enable no format tags in Spring Boot's Eclipse configuration? This would help make the source code more readable. |
@rwinch I think it's already configured, we just don't use it. Feel free to try with them if you prefer. |
@philwebb @rwinch They're switched off at the moment. I've tried turning them on (see wilkinsona@3f5a962). With these changes in place, and after doing |
Hmm, OK. Perhaps we can continue with this one without that and raise a new issue if we feel strongly about disabling auto-formatting. |
@snicoll @philwebb @wilkinsona I submitted a PR #5052 for your review |
Pushing back to 1.3.4. See comments in PR |
duplicates #5052 |
For example, we do not need to use
GlobalAuthenticationConfigurerAdapter
in the following sample:https://github.com/spring-projects/spring-boot/blob/master/spring-boot-samples/spring-boot-sample-web-method-security/src/main/java/sample/ui/method/SampleMethodSecurityApplication.java
Instead we can use
@Autowired
The text was updated successfully, but these errors were encountered: