Skip to content

Health indicators that take a long time to respond are difficult to diagnose #31231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Jun 1, 2022 · 3 comments
Closed

Health indicators that take a long time to respond are difficult to diagnose #31231

philwebb opened this issue Jun 1, 2022 · 3 comments
Assignees
@philwebb
Labels
type: bug A general bug
Milestone
2.6.9

Comments

@philwebb
Copy link
Member

philwebb commented Jun 1, 2022

See #4391 (comment) for background.

It's currently very hard to tell if health indicator will cause a web request timeout as logging only occurs on error. We could offer an option to log health indicators that take a long time to respond.
@philwebb
Copy link
Member Author

philwebb commented Jun 1, 2022

See also #25459

@philwebb
Copy link
Member Author

philwebb commented Jun 1, 2022

This could be considered a usability bug and something we could address in 2.x

@philwebb philwebb added the type: bug A general bug label Jun 1, 2022
@philwebb philwebb added this to the 2.7.x milestone Jun 1, 2022
@philwebb philwebb mentioned this issue Jun 1, 2022
Closed
@wilkinsona wilkinsona changed the title Provide additional logging for health indicators that take a long time to respond Health indicators that take a long time to respond are difficult to diagnose Jun 6, 2022
@wilkinsona
Copy link
Member

I think we should aim to fix this in 2.6.x. If the changes to improve the diagnostics are too risky for the stage we're at in 2.6.x's maintenance, we can always push it out to 2.7.x again.

@wilkinsona wilkinsona modified the milestones: 2.7.x, 2.6.x Jun 6, 2022
@philwebb philwebb self-assigned this Jun 14, 2022
@philwebb philwebb mentioned this issue Jun 14, 2022
Closed
@philwebb philwebb modified the milestones: 2.6.x, 2.6.9 Jun 14, 2022
izeye added a commit to izeye/spring-boot that referenced this issue Jun 28, 2022
@izeye
Polish spring-projectsgh-31231
e84dd69 
See 31231
izeye added a commit to izeye/spring-boot that referenced this issue Jun 28, 2022
@izeye
Polish spring-projectsgh-31231
64a7c17 
See spring-projectsgh-31231
@izeye izeye mentioned this issue Jun 28, 2022
Closed
snicoll pushed a commit that referenced this issue Jul 13, 2022
@izeye @snicoll
Polish gh-31231
b17cb9b 
See gh-31540
snicoll added a commit that referenced this issue Jul 13, 2022
@snicoll
Merge pull request #31540 from izeye
0ef213a 
* pr/31540:
  Polish gh-31231

Closes gh-31540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: bug A general bug
Projects
None yet
Milestone
2.6.9
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona