Skip to content

Relax ImportsContextCustomizer to rely only on a test class name #32421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snicoll opened this issue Sep 19, 2022 · 1 comment
Closed

Relax ImportsContextCustomizer to rely only on a test class name #32421

snicoll opened this issue Sep 19, 2022 · 1 comment
Assignees
Labels
type: task A general task
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Sep 19, 2022

ImportsContextCustomizer currently creates an infrastructure that requires a reference to a test Class but it turns out that only the FQN of the test class is required.

We can relax this private arrangement to only use the name. A side effect of that is that it would prevent spring-projects/spring-framework#29168 from happening.

@snicoll snicoll added the type: task A general task label Sep 19, 2022
@snicoll snicoll added this to the 3.0.0-M5 milestone Sep 19, 2022
@snicoll snicoll changed the title Relax ImportsContextCustomizer to rely only a test class name Relax ImportsContextCustomizer to rely only on a test class name Sep 19, 2022
@snicoll
Copy link
Member Author

snicoll commented Sep 19, 2022

If we decided to not include ImportsContextCustomizer at runtime, then no bean definition would be contributed and that would make this issue irrelevant. However, given that the runtime effectively only need a class name, it makes sense to change this regardless.

@snicoll snicoll self-assigned this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant