Skip to content

Check if we can avoid hard-coding NBT plugin version in image tests #32474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Sep 22, 2022 · 1 comment
Closed

Check if we can avoid hard-coding NBT plugin version in image tests #32474

snicoll opened this issue Sep 22, 2022 · 1 comment
Labels
status: superseded An issue that has been superseded by another type: task A general task

Comments

@snicoll
Copy link
Member

snicoll commented Sep 22, 2022 •
edited
Loading

#32413 has introduced a smoke test for build-image that uses NBT. The version if hard-coded there so I wonder if we can change that to use the "managed" version in gradle.properties like the other placeholders we have.
@snicoll snicoll added the type: task A general task label Sep 22, 2022
@snicoll snicoll added this to the 3.0.x milestone Sep 22, 2022
snicoll added a commit that referenced this issue Sep 22, 2022
@snicoll
Use latest Native Build Tools Plugin version
d7537bf 
See gh-32474
izeye added a commit to izeye/spring-boot that referenced this issue Oct 9, 2022
@izeye
Use NBT plugin version from gradle.properties in image tests
7a13abb 
Closes spring-projectsgh-32474
@izeye izeye mentioned this issue Oct 9, 2022
Closed
@wilkinsona
Copy link
Member

Closing in favor of #32643.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2022
@wilkinsona wilkinsona removed this from the 3.0.x milestone Oct 10, 2022
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use NBT plugin version from gradle.properties in image tests izeye/spring-boot
2 participants
@snicoll @wilkinsona