Skip to content

Allow overriding JobParametersConverter for spring batch auto-configuration #44793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pPanda-beta opened this issue Mar 20, 2025 · 2 comments
Closed

Allow overriding JobParametersConverter for spring batch auto-configuration #44793

pPanda-beta opened this issue Mar 20, 2025 · 2 comments
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@pPanda-beta
Copy link

Since spring-projects/spring-batch#4650 (comment) is closed and there is an way to override the JobParametersConverter in org.springframework.batch.core.configuration.support.DefaultBatchConfiguration it would be very convenient if spring boot auto configuration also allows this.
Right now

class BatchAutoConfiguration.SpringBootBatchConfiguration does not override

protected JobParametersConverter getJobParametersConverter()

spring-boot/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/batch/BatchAutoConfiguration.java

Line 99 in 4a2c26e

static class SpringBootBatchConfiguration extends DefaultBatchConfiguration {

And the only alternative workaround is to utilize the BatchConversionServiceCustomizer and install converters per type, while most parameter objects are data classes, and can easily be handled by json serialization.
Explained in details here

cc: @fmbenhassine
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 20, 2025
@fmbenhassine fmbenhassine mentioned this issue Mar 20, 2025
Closed
@quaff
Copy link
Contributor

quaff commented Mar 20, 2025 •
edited
Loading

What a coincidence! I created PR GH-44799 just now.

quaff added a commit to quaff/spring-boot that referenced this issue Mar 20, 2025
@quaff
Add possibility to configure a custom JobParametersConverter in Batch…
24d03b2 
…AutoConfiguration

Fix spring-projectsGH-44793

Signed-off-by: Yanming Zhou <[email protected]>
@quaff quaff mentioned this issue Mar 20, 2025
Closed
@wilkinsona
Copy link
Member

Closing in favor of #44799. Thanks for the PR, @quaff.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2025
@wilkinsona wilkinsona added type: enhancement A general enhancement status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto-configure Spring Batch to use a JobsParametersConverter bean when available quaff/spring-boot
4 participants
@quaff @wilkinsona @spring-projects-issues @pPanda-beta