Skip to content

OnBeanCondition doesn't implement SearchStrategy.PARENTS as documented #6762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Aug 26, 2016 · 0 comments · May be fixed by ivanpokupec/spring-boot#1
Closed

OnBeanCondition doesn't implement SearchStrategy.PARENTS as documented #6762

wilkinsona opened this issue Aug 26, 2016 · 0 comments · May be fixed by ivanpokupec/spring-boot#1
Assignees
@wilkinsona
Labels
type: bug A general bug
Milestone
1.3.8

Comments

@wilkinsona
Copy link
Member

The javadocs says that PARENTS will "Search all parents and ancestors, but not the current context", however OnBeanCondition only looks in the parent and ignores any older ancestors.
@wilkinsona wilkinsona added the type: bug A general bug label Aug 26, 2016
@wilkinsona wilkinsona changed the title OnBeanCondition doesn't implements SearchStrategy.PARENTS as documented OnBeanCondition doesn't implement SearchStrategy.PARENTS as documented Aug 27, 2016
ivanpokupec added a commit to ivanpokupec/spring-boot that referenced this issue Aug 30, 2016
@ivanpokupec
Fixed bug mentioned in spring-projects#6762
f46130e 
The whole hierarchy should be searched when SearchStrategy.PARENTS is also used

Fixes spring-projectsgh-6762
This was referenced Aug 30, 2016
Open
Closed
@wilkinsona wilkinsona added this to the 1.3.8 milestone Aug 31, 2016
@wilkinsona wilkinsona self-assigned this Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: bug A general bug
Projects
None yet
Milestone
1.3.8
1 participant
@wilkinsona