Skip to content

Consider splitting Redis connection factory and RedisTemplate related configs #8583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vpavic opened this issue Mar 12, 2017 · 4 comments
Closed

Consider splitting Redis connection factory and RedisTemplate related configs #8583

vpavic opened this issue Mar 12, 2017 · 4 comments
Labels
status: duplicate A duplicate of another issue

Comments

@vpavic
Copy link
Contributor

vpavic commented Mar 12, 2017

Currently the entire Redis auto-configuration is conditional on presence of Jedis. If one uses Lettuce and provides LettuceConnectionFactory bean it would be nice if Boot would configure RedisTemplate and StringRedisTemplate just like it does with Jedis.

I'm aware of Lettuce first-class support proposed in #5311 is scheduled for Boot 2.0 however the situation described above would benefit Boot 1.x users as well.

Thoughts? I understand this is not a trivial change however if you'd consider it acceptable for 1.5 I'd put together a PR.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 12, 2017
@philwebb
Copy link
Member

My gut instinct is that this would be quite a large change to sneak into 1.5.x. I'd be interested in what others think, but my initial feeling is that we should leave 1.5.x as it is and instead focus on splitting things up for 2.0.0.

@philwebb philwebb added for: team-attention An issue we'd like other members of the team to review priority: normal status: on-hold We can't start working on this issue yet type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 13, 2017
@snicoll
Copy link
Member

snicoll commented Mar 13, 2017

I agree. We do have plans to support Lettuce so that would be a change we'll have to make anyway.

@philwebb
Copy link
Member

Having discussed this a bit we feel like the change will be too large for the maintenance release. We'll take this on in 2.0 as part of #5311.

@philwebb philwebb removed for: team-attention An issue we'd like other members of the team to review status: on-hold We can't start working on this issue yet labels Mar 30, 2017
@philwebb philwebb modified the milestones: 2.0.0, 2.0.0.M2 Mar 30, 2017
@vpavic
Copy link
Contributor Author

vpavic commented May 2, 2017

This was resolved via #5311. I guess that means the milestone should be adjusted to 2.0.0.M1.

@vpavic vpavic closed this as completed May 2, 2017
@snicoll snicoll added status: duplicate A duplicate of another issue and removed priority: normal type: enhancement A general enhancement labels May 2, 2017
@snicoll snicoll removed this from the 2.0.0.M2 milestone May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snicoll @philwebb @vpavic @spring-projects-issues