-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Add lettuce Redis driver autoconfiguration. #5311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lettuce Redis driver autoconfiguration. #5311
Conversation
f8a8c3d
to
d0b063f
Compare
I think this requires a bit more thought (and possibly some breaking changes). We currently have some I am not keen on |
I reacted with 👍 so maybe you didn't get the notification. Note also that |
2c1448c
to
347afe6
Compare
Thanks for your feedback. I addressed your comments and pushed new commits, rebased to master. |
347afe6
to
9a8649f
Compare
a09992a
to
99b6590
Compare
I would really like to see this support too. The lettuce driver uses multiplexing which reduces the overall connections to Redis. This means the lettuce driver works much better with Spring Session. In fact, the Pivotal CLA tooling switched to Lettuce due to larger number of connections causing alerting on our Redis instance. |
Moving to 2.0 as Lettuce 4.x requires Java8 |
4f8ceae
to
ee2cb13
Compare
This PR will be reworked by @mp911de once breaking changes in Kay have landed on master |
Introduce an alternative autoconfiguration if the lettuce Redis driver is available. Add Lettuce-specific configuration property options "spring.redis.lettuce.shutdown-timeout" to control the shutdown timeout of the lettuce driver. Add documentation for the properties, the supported drivers, and how to switch between drivers. Split client-specific properties from spring.redis.pool to spring.redis.jedis.pool and introduce spring.redis.lettuce namespace. Deprecate spring.redis.pool property.
ee2cb13
to
8ad8d37
Compare
Introduce an alternative autoconfiguration if the lettuce Redis driver is available. Add Lettuce-specific configuration property options "spring.redis.lettuce.shutdown-timeout" to control the shutdown timeout of the lettuce driver. Add documentation for the properties, the supported drivers, and how to switch between drivers. Split client-specific properties from spring.redis.pool to spring.redis.jedis.pool and introduce spring.redis.lettuce namespace. Deprecate spring.redis.pool property. See gh-5311
…utoconfiguration * pr/5311: Add missing tests Polish "Add Lettuce Redis driver autoconfiguration" Add Lettuce Redis driver autoconfiguration
Thank you so much @mp911de! |
Introduce an alternative autoconfiguration if the lettuce Redis driver is available. Add lettuce-specific configuration property options
spring.redis.lettuce.shutdown-timeout
to control the shutdown timeout of the lettuce driver. Add documentation for the properties, the supported drivers, and how to switch between drivers.Jedis stays the default driver even if both libraries are on the classpath.