Skip to content

Reconsider the choice of Redis driver in spring-session-data-redis #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vpavic opened this issue Jun 16, 2017 · 0 comments · Fixed by #824
Closed

Reconsider the choice of Redis driver in spring-session-data-redis #802

vpavic opened this issue Jun 16, 2017 · 0 comments · Fixed by #824
Assignees
Labels
in: build An issue in the build in: redis type: enhancement A general enhancement
Milestone

Comments

@vpavic
Copy link
Contributor

vpavic commented Jun 16, 2017

Our Data Redis module (spring-session-data-redis) currently pulls in Jedis.

With Lettuce getting more attention recently which includes the first-class support in Boot (see spring-projects/spring-boot#5311) and potentially becoming the default Redis driver in Boot's spring-boot-starter-data-redis (see spring-projects/spring-boot#9536) it's an obvious choice for our Data Redis module. We already use Lettuce instead of Jedis in some of our sample apps.

The third option is not to include Redis driver at all in our Data Redis module and leave the choice to user. The rationale behind this is that we don't actually configure RedisConnectionFactory but rather expect it provided to us (see RedisHttpSessionConfiguration:109) - following that it might makes sense for us not to pull in a Redis driver and leave that choice to user to either declare the desired Redis driver as first-level dependency or rely on Spring Boot to provide dependency for the driver (since it actually configures it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build in: redis type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant