Skip to content

Improve dependency management #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Jul 6, 2017

This PR improves dependency management with the following changes:

  • spring-session-core: move javax.servlet-api from provided to optional configuration due to introduction of reactive support
  • spring-session-data-redis: remove Redis driver from compile configuration
  • Boot samples: delegate Redis driver choice to spring-boot-starter-data-redis
  • polish test configuration dependencies

This also resolves #802.

This commit improves dependency management with the following changes:

 - `spring-session-core`: move `javax.servlet-api` from `provided` to `optional` configuration due to introduction of reactive support
 - `spring-session-data-redis`: remove Redis driver from `compile` configuration
 - Boot samples: delegate Redis driver choice to `spring-boot-starter-data-redis`
 - polish `test` configuration dependencies
@vpavic vpavic added in: build An issue in the build type: enhancement A general enhancement labels Jul 6, 2017
@vpavic vpavic added this to the 2.0.0.M3 milestone Jul 6, 2017
@rwinch rwinch merged commit 5845a9c into spring-projects:master Jul 6, 2017
@vpavic vpavic deleted the improve-dependencies branch July 6, 2017 22:18
vpavic added a commit that referenced this pull request Jul 10, 2017
This commit removes needless dependency exclusions.

See gh-824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider the choice of Redis driver in spring-session-data-redis
2 participants