Skip to content

Refactor NettyWebServer startup algorithm #9698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Jul 7, 2017 · 0 comments
Closed

Refactor NettyWebServer startup algorithm #9698

bclozel opened this issue Jul 7, 2017 · 0 comments
Assignees
@bclozel @mbhave
Labels
type: enhancement A general enhancement
Milestone
2.0.0.M3

Comments

@bclozel
Copy link
Member

bclozel commented Jul 7, 2017

The latest reactor-netty snapshots introduced a new method for starting the server and awaiting, without manually creating a daemon thread: HttpServer.startAndAwait(T handler, Consumer<BlockingNettyContext> onStart).

We can now safely remove the await Thread and managing the atomic reference on the netty context.
@bclozel bclozel added priority: high type: enhancement A general enhancement labels Jul 7, 2017
@bclozel bclozel added this to the 2.0.0.M3 milestone Jul 7, 2017
@bclozel bclozel self-assigned this Jul 7, 2017
@mbhave mbhave self-assigned this Jul 10, 2017
@mbhave mbhave mentioned this issue Jul 13, 2017
Closed
bclozel added a commit that referenced this issue Jul 18, 2017
@bclozel
Clean NettyWebServer tests
2094323 
Remove ununsed tests after gh-9698
@bclozel bclozel mentioned this issue Aug 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

@mbhave mbhave

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.0.0.M3
Development

No branches or pull requests
2 participants
@bclozel @mbhave