Skip to content

Use Commons Logging for OnlyOnceLoggingDenyMeterFilter #14637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use Commons Logging for OnlyOnceLoggingDenyMeterFilter #14637

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Sep 29, 2018

This PR changes to use Commons Logging for OnlyOnceLoggingDenyMeterFilter as it seems that SLF4J is used accidentally.

@snicoll snicoll added the type: task A general task label Sep 29, 2018
@snicoll snicoll added this to the 2.1.x milestone Sep 29, 2018
@snicoll snicoll self-assigned this Sep 29, 2018
@izeye
Copy link
Contributor Author

izeye commented Sep 30, 2018

I missed dropping this keywords for logger as I changed it to static. I updated it now.

@snicoll snicoll modified the milestones: 2.1.x, 2.1.0.RC1 Sep 30, 2018
@snicoll snicoll closed this in 1e756db Sep 30, 2018
snicoll added a commit that referenced this pull request Sep 30, 2018
@snicoll
Merge pull request #14637 from izeye
42a77a0 
* pr/14637:
  Use Commons Logging for OnlyOnceLoggingDenyMeterFilter
@izeye izeye deleted the slf4j branch September 30, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snicoll snicoll snicoll approved these changes

Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.1.0.RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@izeye @snicoll