Skip to content

Adjust to changes in Spring AMQP 2.2 snapshots #17587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dreis2211
Copy link
Contributor

Hi,

this PR should fix the current build caused by a number of changes in the newest AMQP snapshots.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 19, 2019
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 19, 2019
@snicoll snicoll self-assigned this Jul 19, 2019
@snicoll snicoll added this to the 2.2.0.M5 milestone Jul 19, 2019
@wilkinsona
Copy link
Member

Thank you, @dreis2211. I had been looking at this too and have a slightly different take on it here.

@dreis2211
Copy link
Contributor Author

Looks similar to me - apart from the fail-safe not to use both at the same time (which I like). Also commented on the change in DispatcherServletAutoConfiguration that seems unrelated.

Feel free to close this PR. :-)

@wilkinsona
Copy link
Member

Thanks, @dreis2211. @snicoll seems to like a mix of the two :)

@dreis2211
Copy link
Contributor Author

Teamwork 💪

snicoll pushed a commit that referenced this pull request Jul 19, 2019
@snicoll snicoll closed this in afe3ab7 Jul 19, 2019
@snicoll
Copy link
Member

snicoll commented Jul 19, 2019

I agree, this Community rocks. Thank you so much again Christoph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants