Restore disabled tests in TomcatReactiveWebServerFactoryTests #19718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the suggestion, @dreis2211. We’ll be upgrading to Netty 4.1.44 (or even 4.1.45) prior to the next batch of releases so if we merged this we’d only have to revert it again. |
wilkinsona
added
status: declined
|
Fair enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
given that the publishing of Gradle module metadata was disabled again for now and we're back on using enforced platforms #19702 I think we can restore the tests in
TomcatReactiveWebServerFactoryTests. What do you think?Cheers,
Christoph