Skip to content

Legacy endpoint ids with '-' do not migrate cleanly #21615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Larisho
Copy link
Contributor

@Larisho Larisho commented May 28, 2020

This is a fix for the partially fixed legacy compatibility flag management.endpoints.migrate-legacy-ids. After the first fix, warnings were still issued when endpoint ids contained a hyphen. This bugfix extends the flag's effects to the hyphen as well as the previously implement dot. See #20703 and #18148 for more context around the issue.

@pivotal-issuemaster
Copy link

@Larisho Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@Larisho Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 28, 2020
@philwebb philwebb self-assigned this May 29, 2020
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 29, 2020
@philwebb philwebb added this to the 2.2.x milestone May 29, 2020
@philwebb philwebb changed the title Fixes partially fixed migration of legacy endpoint ids #20703 Legacy endpoint ids with '-' do not migrate cleanly May 29, 2020
snicoll pushed a commit that referenced this pull request Aug 10, 2020
@snicoll snicoll self-assigned this Aug 10, 2020
@snicoll snicoll modified the milestones: 2.2.x, 2.2.10 Aug 10, 2020
@snicoll snicoll closed this in afe99ad Aug 10, 2020
@snicoll
Copy link
Member

snicoll commented Aug 10, 2020

@Larisho thank you for making your first contribution to Spring Boot.

@Larisho
Copy link
Contributor Author

Larisho commented Aug 10, 2020

@snicoll My pleasure; would love to do more.

Could you explain to me what forward port means with regards to the PR? Thanks

@snicoll
Copy link
Member

snicoll commented Aug 10, 2020

Could you explain to me what forward port means with regards to the PR? Thanks

Gladly. This bug had to be fixed in the 2.2.x line so we first applied the fix there. We then merged the fix forward to 2.3.x and then master. We want to track the fact this bug was fixed in each release notes (2.2.10, 2.3.3 and 2.4.0-M2 respectively). We have a script that creates automatically an issue when we merge forward and the label is used to indicate this issue is only created for the purpose of tracking the change in a different feature release.

There is a bit more details on our wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants