Skip to content

RSocketPortInfoApplicationContextInitializer can throw NPE #23084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ private static class Listener implements ApplicationListener<RSocketServerInitia

@Override
public void onApplicationEvent(RSocketServerInitializedEvent event) {
setPortProperty(this.applicationContext, event.getServer().address().getPort());
if (event.getServer().address() != null) {
setPortProperty(this.applicationContext, event.getServer().address().getPort());
}
}

private void setPortProperty(ApplicationContext context, int port) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
/*
* Copyright 2012-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.boot.rsocket.context;

import java.net.InetSocketAddress;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.rsocket.server.RSocketServer;
import org.springframework.boot.rsocket.server.RSocketServerException;
import org.springframework.context.ApplicationEventPublisher;
import org.springframework.context.ConfigurableApplicationContext;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.test.context.junit.jupiter.SpringExtension;

@ExtendWith(SpringExtension.class)
public class RSocketPortInfoApplicationContextInitializerTests {

@Autowired
private RSocketPortInfoApplicationContextInitializer initializer;

@Autowired
private ConfigurableApplicationContext context;

@Autowired
private ApplicationEventPublisher publisher;

@Test
void nullAddressDoesNotThrow() {
initializer.initialize(context);
publisher.publishEvent(new RSocketServerInitializedEvent(new RSocketServer() {
@Override
public void start() throws RSocketServerException {

}

@Override
public void stop() throws RSocketServerException {

}

@Override
public InetSocketAddress address() {
return null;
}
}));
}

@Configuration(proxyBeanMethods = false)
static class Config {

@Bean
public RSocketPortInfoApplicationContextInitializer rSocketPortInfoApplicationContextInitializer() {
return new RSocketPortInfoApplicationContextInitializer();
}
}
}