Layertools may extract entries outside of the destination path#25505
Closed
trgpa wants to merge 1 commit into
Closed
Layertools may extract entries outside of the destination path#25505trgpa wants to merge 1 commit into
trgpa wants to merge 1 commit into
Conversation
Member
|
Thanks for the proposal but I am not sure that this change is necessary due to this existing line: Cleaning the path should resolve any |
Member
|
No, it is necessary. For example, the path for a |
wilkinsona
pushed a commit
that referenced
this pull request
Mar 5, 2021
wilkinsona
added a commit
that referenced
this pull request
Mar 5, 2021
Member
|
Thanks very much for making your first contribution to Spring Boot, @trungPa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for subdirectory in ExtractCommand.java will always return true because
getAbsolutePathdoes not resolve..and symlinks.This PR uses
getCanonicalPathand adds a file separator at the end of destination path to avoid treating directories with the same prefix as subdirectories (e.g /foo, /foobar).