Incorrect ConfigurationMetadataRepository when loaded from json files containing properties of the same group #25507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is based on the existing “severalRepositoriesIdenticalGroups” test. It loads “foo” and “foo3”. “foo3” is a copy of “foo2”: it has the same properties except they refer to a group that already exists in “foo” with the same name and *TYPE*.
spring-projects-issues
added
the
status: waiting-for-triage
brenuart
changed the title
brenuart
changed the title
snicoll
added
type: bug
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Mar 5, 2021
This commit improves SimpleConfigurationMetadataRepository to include properties that are contributed to an existing configuration metadata source. See gh-25507
snicoll
added a commit
that referenced
this pull request
Mar 5, 2021
|
@brenuart thank you for making your first contribution to Spring Boot. |
|
@snicoll Definitely not my first but always happy to contribute ;-) |
|
Apologizes for that Bertrand. You had a "first time contributor" badge on your PR and I didn't remember. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a simple test case to illustrate issue described in #25501.
It is based on the existing
severalRepositoriesIdenticalGroupstest. It loads “foo” and “foo3”.“foo3” is a copy of “foo2”: it has the same properties except they refer to a group that already exists in “foo” with the same name and TYPE.
Please note that the test will obviously FAIL ;-)