Skip to content

Defer OIDC lookup until first use of the issuer location JwtDecoder #28169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Defer OIDC lookup until first use of the issuer location JwtDecoder #28169

wants to merge 4 commits into from

Conversation

Pooja199
Copy link
Contributor

@Pooja199 Pooja199 commented Oct 1, 2021 •
edited
Loading

This is the issue I have fixed is #28122

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 1, 2021
@Pooja199 Pooja199 changed the title #28122 - Defer OIDC lookup until first use of the issuer location JwtDecoder Use JwtSupplierDecoder when jwt issuer uri bean is instantiated Oct 1, 2021
@mbhave mbhave mentioned this pull request Oct 1, 2021
Closed
@wilkinsona wilkinsona changed the title Use JwtSupplierDecoder when jwt issuer uri bean is instantiated Defer OIDC lookup until first use of the issuer location JwtDecoder Oct 4, 2021
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 4, 2021
@wilkinsona wilkinsona added this to the 2.6.x milestone Oct 4, 2021
@mbhave
Copy link
Contributor

mbhave commented Oct 5, 2021

Spring Security made a change that defers the call to get the signature algorithm once decode is actually called. This is causing the tests in ReactiveOAuth2ResourceServerAutoConfigurationTests.java to fail because the number of requests to the mock server is different. We will need to update the assertions as part of merging this PR.

@wilkinsona wilkinsona added the for: merge-with-amendments Needs some changes when we merge label Oct 6, 2021
mbhave pushed a commit that referenced this pull request Oct 7, 2021
@Pooja199 @mbhave
Auto-configure JwtSupplierDecoder to defer OIDC lookup
4e9f536 
See gh-28169
@mbhave mbhave closed this in e571894 Oct 7, 2021
@mbhave
Copy link
Contributor

mbhave commented Oct 7, 2021

@Pooja199 Thank you for making your first contribution to Spring Boot! This has now been merged into main.

@mbhave mbhave modified the milestones: 2.6.x, 2.6.0-RC1 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement
Projects
None yet
Milestone
2.6.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@Pooja199 @mbhave @wilkinsona @spring-projects-issues