-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Add smoke test with Spring Session and Hazelcast #28173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kandulsh Thanks for the pull request! This has now been merged into main along with this polish commit which added some changes to assert on the number of sessions. |
IMO the tests are more complicated then necessary as they are testing the |
Thanks for taking a look, Vedran. I prefer the test as currently written. At the level of a smoke test, I think it's better to check that a particular feature is working as a user would expect, rather than checking for the presence of some underlying components that enable that feature. |
Fair enough - I didn't consider the user perspective to still be of primary interest here since these aren't considered samples so I focused on the actual touching points of Spring Boot's integration for Spring Session. |
What @wilkinsona said is my preference for smoke tests as well. Even if they aren't meant to be consumed as samples, the tests should test what the high-level feature is to make sure nothing in between is broken. |
Added smoke test with spring session and Hazelcast