Change identityprovider to asserting-party in Saml2RelyingPartyProperties #30742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snicoll
reviewed
Apr 19, 2022
.../java/org/springframework/boot/autoconfigure/security/saml2/Saml2RelyingPartyProperties.java
Outdated
Show resolved
Hide resolved
...ringframework/boot/autoconfigure/security/saml2/Saml2RelyingPartyAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
Rename spring.security.saml2.relyingparty.registration.*.identity-provider.* to spring.security.saml2.relyingparty.registration.*.asserting-party.* The old property names are still supported, but will lead to a warning in the logs. Closes spring-projectsgh-30642
mhalbritter
force-pushed
the
mh/30642-change-identityprovider-to-assertingparty-in-saml2relyingpartyproperties
branch
from
bf92a01 to
21c0b79
Compare
mhalbritter
deleted the
mh/30642-change-identityprovider-to-assertingparty-in-saml2relyingpartyproperties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit of a hassle, because the properties-migrator can't be used for map-based types, which the
identityprovideris (see #9945). I had to write codepaths for both the old and the new property names, and a warning is logged if the old one is used. I adjusted the tests to test with both the old and the new names.I had to change
private boolean signRequest = true;toprivate Boolean signRequest;to get the fallback working. This doesn't make a difference, because this only gets applied if!= null. And the default in Spring Security is true for that field (seeorg.springframework.security.saml2.provider.service.registration.RelyingPartyRegistration.AssertingPartyDetails.Builder#wantAuthnRequestsSigned).Closes gh-30642